Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove files with invalid characters from the FeatureFiles list (provided by msbuild) #1961

Merged
merged 6 commits into from
Apr 28, 2020
Merged

Remove files with invalid characters from the FeatureFiles list (provided by msbuild) #1961

merged 6 commits into from
Apr 28, 2020

Conversation

epresi
Copy link
Contributor

@epresi epresi commented Apr 28, 2020 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

SabotageAndi
SabotageAndi suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@SabotageAndi SabotageAndi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the one method and add an entry to the changelog.

TechTalk.SpecFlow/Assist/FileFilter.cs Outdated Show resolved Hide resolved
@epresi
Copy link
Contributor Author

epresi commented Apr 28, 2020 •
edited
Loading

Please remove the one method and add an entry to the changelog.

Changelog adjusted and branch rebased on master

@SabotageAndi SabotageAndi merged commit 65c53ef into master Apr 28, 2020
@SabotageAndi SabotageAndi deleted the 1886-illegal-characters branch April 28, 2020 13:19
This was referenced May 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasparnagy gasparnagy gasparnagy requested changes

@SabotageAndi SabotageAndi SabotageAndi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epresi @gasparnagy @SabotageAndi